Skip to content

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented May 1, 2020

r? @Mark-Simulacrum

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!
  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2020
@cuviper
Copy link
Member Author

cuviper commented May 1, 2020

@Amanieu -- using the same stdarch commit as #71495 brings a few other things to stable too, which had only reached beta so far. I was able to shim llvm_asm! to plain asm!, but please review whether the rest is safe for stable backport. Otherwise, we'll need a separate stdarch branch to use here.

@Amanieu
Copy link
Member

Amanieu commented May 1, 2020

The other commits only affect ARM instrinsics which are all unstable. So I think it should be safe to backport.

@Mark-Simulacrum
Copy link
Member

I agree that the stdarch backport seems fine as-is.

I'm going to hold off on approving until Sunday to give some time for feedback (in case someone thinks of something else to include).

@Mark-Simulacrum
Copy link
Member

@sfackler nominated rust-lang/cargo#8151 (PR: rust-lang/cargo#8175) for backport as well, which is waiting on Cargo team approval.

@cuviper
Copy link
Member Author

cuviper commented May 2, 2020

OK, this PR should be open to maintainer pushes, if you want to add that.

@Mark-Simulacrum
Copy link
Member

Yeah, I'd like someone from cargo team to sign off and then I'll do so before approving.

@Mark-Simulacrum
Copy link
Member

Closing in favor of #71868, wasn't able to push to this branch for whatever reason.

@cuviper cuviper deleted the stable-1.43.1 branch May 30, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants